Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: p12sp2 uav phase improvements #5634

Merged
merged 8 commits into from
Jul 2, 2023
Merged

raidboss: p12sp2 uav phase improvements #5634

merged 8 commits into from
Jul 2, 2023

Conversation

wexxlee
Copy link
Contributor

@wexxlee wexxlee commented Jul 1, 2023

Sorry for the piecemeal PRs today - I keep ending up with more time on my hands than I thought.

This adds a preposition 'stack for tethers' call before both of the player-chain-break mechs during uav phases. It also adds directional safe calls for the ultima ray (clone) dives, and combines the 'break tethers' call with the geocentrism call during uav2.

@quisquous
Copy link
Owner

Sorry for the piecemeal PRs today

Oh no, I tried to say this in the contributing guide, but more smaller PRs are WAY better than giant PRs. It's easier to review because there's fewer parts, it gets merged quicker (so I don't have to rereview a huge patch and try to keep it all in my head), and also if there's one part that gets a bunch of discussion it doesn't hold up everything else.

ui/raidboss/data/06-ew/raid/p12s.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/raid/p12s.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/raid/p12s.ts Show resolved Hide resolved
ui/raidboss/data/06-ew/raid/p12s.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/raid/p12s.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/raid/p12s.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/raid/p12s.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the 💬cn label Jul 1, 2023
ui/raidboss/data/06-ew/raid/p12s.ts Show resolved Hide resolved
ui/raidboss/data/06-ew/raid/p12s.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/raid/p12s.ts Outdated Show resolved Hide resolved
@quisquous quisquous merged commit 09508e5 into quisquous:main Jul 2, 2023
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 2, 2023
Sorry for the piecemeal PRs today - I keep ending up with more time on
my hands than I thought.

This adds a preposition 'stack for tethers' call before both of the
player-chain-break mechs during uav phases. It also adds directional
safe calls for the ultima ray (clone) dives, and combines the 'break
tethers' call with the geocentrism call during uav2. 09508e5
github-actions bot pushed a commit that referenced this pull request Jul 2, 2023
Sorry for the piecemeal PRs today - I keep ending up with more time on
my hands than I thought.

This adds a preposition 'stack for tethers' call before both of the
player-chain-break mechs during uav phases. It also adds directional
safe calls for the ultima ray (clone) dives, and combines the 'break
tethers' call with the geocentrism call during uav2. 09508e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants