Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of albumartistsort as TSO2 and TXXX:ALBUMARTISTSORT in EasyID3 #649

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix handling of albumartistsort as TSO2 and TXXX:ALBUMARTISTSORT in EasyID3 #649

wants to merge 3 commits into from

Commits on Jun 14, 2024

  1. Fix duplicated albumartistsort key 

    albumartistsort was already added as a registered Text key
some lines above so adding it again as a TXXX key replaces
the previous TSO2 tag registration.

Since picard uses TSO2 for "album artist sort order" and even
if it's not an official tag it seems to be generally supported,
I think it's better to leave that one.
    @antlarr
    antlarr committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    e90ec46 View commit details
    Browse the repository at this point in the history

  2. Add test for correct handling of albumartistsort as TSO2 

    This tests that albumartistsort is handled by the TSO2 frameid.
    @antlarr
    antlarr committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    11629ef View commit details
    Browse the repository at this point in the history

  3. Allow TXXX:ALBUMARTISTSORT to be a fallback for albumartistsort 

    I noticed that my previous fix for duplicate key registration of
albumartistsort would break reading files already having
TXXX:ALBUMARTISTSORT so this commit fixes it by making
TXXX:ALBUMARTISTSORT a fallback for albumartistsort if the first
getter can't get a value and also by making EasyID3 delete
TXXX:ALBUMARTISTSORT frames when deleting albumartistsort.

Still, when setting an albumartistsort value only TSO2 frames
are used.

This also adds tests for all those cases.
    @antlarr
    antlarr committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ec25722 View commit details
    Browse the repository at this point in the history