-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown support #421
Comments
It looks like most Matrix clients render the Markdown to HTML on the clientside then send it as an HTML message. |
What if we use basic RTF support that Qt already has? Qt can also easily convert it to HTML but unfortunately the set is richer (and uses CSS) than that supported by Riot. |
I did some experimenting with the RTF in QT and while I still think that isn't a bad way to go, it's not the best. The big issue with it is that when it generates HTML it makes a full valid HTML document when we need just a a smaller portion. That mixed with trying to only expose a subset of the RTF functionality to users makes it rather hard to use. So I am thinking it would be best if we either found a Markdown library to use (as much as I hate adding dependencies) or wrote our own parser for a Markdown subset (also not a great idea). |
I have experimental Markdown support working on my fork: https://github.com/rushsteve1/Quaternion/tree/cmark It uses CommonMark which... To be honest isn't great. It doesn't support some common features such as underline and |
So far I feel that functionality of Markdown is so small that integrating another library may bring more overheads than benefits, compared to the homebaked code. Just an observation. |
Qt 5.14+ supports Markdown; #701 has a proof-of-concept in the form of |
As of 0.0.9.5, there's |
Part of the fix for quotient-im#421. (cherry picked from commit 104356d945671762af23e346f7898a3208770d97)
Proxy servers may return arbitrary HTML, for one example; so don't expect to find a valid JSON object in whatever non-empty payload next to a non-2xx HTTP code. Fixes quotient-im#421. (cherry picked from commit 9ef83e044ed4f8409156b19d529dfc7e45f565c1)
especially when writing
The text was updated successfully, but these errors were encountered: