Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mmahalwy committed Nov 10, 2016
1 parent 0880f9e commit 10d0bc2
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 19 deletions.
2 changes: 2 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ ENV NODE_ENV production
ENV API_URL http://api.quran.com:3000
ENV SENTRY_KEY_CLIENT https://44c105328ae544ae9928f9eb74b40061@app.getsentry.com/80639
ENV SENTRY_KEY_SERVER https://44c105328ae544ae9928f9eb74b40061:41ca814d33124e04ab450104c3938cb1@app.getsentry.com/80639
# It's okay because it's only the APP ID
ENV FACEBOOK_APP_ID 1557596491207315
ENV PORT 8000
ENV NODE_PATH "./src"

Expand Down
7 changes: 3 additions & 4 deletions src/components/IndexHeader/Nav/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import React, { Component, PropTypes } from 'react';
import Link from 'react-router/lib/Link';
import { connect } from 'react-redux';


export class IndexHeaderNav extends Component {
static propTypes = {
user: PropTypes.object
Expand All @@ -12,15 +11,15 @@ export class IndexHeaderNav extends Component {
open: false
};

openNav(e) {
e.preventDefault();
openNav(event) {
event.preventDefault();

this.setState({open: !this.state.open});
}

links() {
const { user } = this.props;
let classNames = `links ${this.state.open ? 'open' : ''}`;
const classNames = `links ${this.state.open ? 'open' : ''}`;

return (
<ul className={classNames}>
Expand Down
19 changes: 6 additions & 13 deletions src/containers/Login/index.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,9 @@
import React, { Component } from 'react';
import React from 'react';

import FacebookButton from 'components/FacebookButton';

export default class Login extends Component {
something() {

}
render() {
return (
<div>
<FacebookButton />
</div>
);
}
}
export default () => (
<div>
<FacebookButton />
</div>
);
4 changes: 2 additions & 2 deletions src/containers/Profile/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import Col from 'react-bootstrap/lib/Col';
import Image from 'react-bootstrap/lib/Image';

import QuranNav from 'components/QuranNav';
import userType from 'types/userType';

const styles = require('./style.scss');

Expand All @@ -17,10 +18,9 @@ const styles = require('./style.scss');
)
export default class Profile extends Component {
static propTypes = {
user: PropTypes.object
user: PropTypes.shape(userType)
};

something() {}
render() {
const { user } = this.props;

Expand Down
13 changes: 13 additions & 0 deletions src/types/userType.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { PropTypes } from 'react';

export default {
provider: PropTypes.string,
uid: PropTypes.string,
firstName: PropTypes.string,
lastName: PropTypes.string,
username: PropTypes.string,
link: PropTypes.string,
image: PropTypes.string,
email: PropTypes.string,
name: PropTypes.string
};

0 comments on commit 10d0bc2

Please sign in to comment.