#568 UI improvements (#583)

* moved topoptions to navbar drawer * fix lint * fix tests * break eslint * fix eslint * fix test * verse dropdown max height * Global Nav * small bug * change again * placeholder for search * global nav edits and to merge so one pr * a ton of changes and i want to sleep now * fix test * remove unneeded * more delete * fix errors * fixes ##561 * console * delete that * minor style changes * pr comments * fixes audio * always close
quran · Jan 18, 2017 · 8948a58 · 8948a58
1 parent 575227b
commit 8948a58
Show file tree

Hide file tree

Showing 76 changed files with 1,994 additions and 1,196 deletions.
diff --git a/package.json b/package.json
@@ -6,14 +6,14 @@
   "scripts": {
     "test": "npm run test:dev:unit",
     "test:ci:unit": "karma start --browsers PhantomJS --single-run",
-    "posttest:ci:unit": "npm run test:ci:lint",
+    "pretest:ci:unit": "npm run test:ci:lint",
     "test:ci:functional": "BROWSER=phantomjs ./tests/functional/test.sh start-ci",
     "posttest:ci:functional": "./tests/functional/test.sh stop",
     "test:dev:unit": "karma start",
-    "test:ci:lint": "./node_modules/eslint/bin/eslint.js ./src/**/*.js",
+    "test:ci:lint": "./node_modules/eslint/bin/eslint.js ./src",
     "test:dev:functional": "BROWSER=chrome ./tests/functional/test.sh start",
     "posttest:dev:functional": "./tests/functional/test.sh stop",
-    "test:dev:lint": "eslint ./src/scripts/**/*.js",
+    "test:dev:lint": "./node_modules/eslint/bin/eslint.js ./src",
     "test:stylelint": "stylelint './src/**/*.scss' --config ./webpack/.stylelintrc",
     "dev": "env NODE_PATH='./src' PORT=8000 UV_THREADPOOL_SIZE=100 node ./webpack/webpack-dev-server.js & env NODE_PATH='./src' PORT=8000 node ./bin/server.js",
     "start": "NODE_PATH='src' node ./start",

diff --git a/src/components/Ayah/index.js b/src/components/Ayah/index.js
@@ -9,8 +9,6 @@ import Word from 'components/Word';
 
 import debug from 'helpers/debug';
 
-import bindTooltip from 'utils/bindTooltip';
-
 const styles = require('./style.scss');
 
 export default class Ayah extends Component {
@@ -48,10 +46,6 @@ export default class Ayah extends Component {
     isSearched: false
   };
 
-  componentDidMount() {
-    bindTooltip();
-  }
-
   shouldComponentUpdate(nextProps) {
     const conditions = [
       this.props.ayah !== nextProps.ayah,
@@ -99,7 +93,7 @@ export default class Ayah extends Component {
           <h4 className="montserrat">{content.name || content.resource.name}</h4>
           <h2 className={`${isArabic ? 'text-right' : 'text-left'} text-translation times-new`}>
             <small
-              dangerouslySetInnerHTML={{__html: content.text}}
+              dangerouslySetInnerHTML={{ __html: content.text }}
               className={`${lang || 'times-new'}`}
             />
           </h2>
@@ -148,20 +142,22 @@ export default class Ayah extends Component {
   }
 
   renderText() {
-    const { ayah, tooltip, currentAyah, isPlaying,  audioActions, isSearched} = this.props;
-
-    const text = ayah.words.map(word => {
-      return(
-        <Word
-          word={word}
-          currentAyah={currentAyah}
-          tooltip={tooltip}
-          isPlaying={isPlaying}
-          audioActions={audioActions}
-          isSearched={isSearched}
-        />
-      )
-    });
+    const { ayah, tooltip, currentAyah, isPlaying, audioActions, isSearched } = this.props;
+    // NOTE: Some 'word's are glyphs (jeem). Not words and should not be clicked for audio
+    let wordAudioPosition = -1;
+
+    const text = ayah.words.map(word => ( // eslint-disable-line
+      <Word
+        word={word}
+        key={`${word.position}-${word.code}-${word.lineNum}`}
+        currentAyah={currentAyah}
+        tooltip={tooltip}
+        isPlaying={isPlaying}
+        audioActions={audioActions}
+        audioPosition={word.wordId ? wordAudioPosition += 1 : null}
+        isSearched={isSearched}
+      />
+    ));
 
     return (
       <h1 className={`${styles.font} text-right text-arabic`}>
@@ -187,7 +183,7 @@ export default class Ayah extends Component {
           onClick={() => this.handlePlay(ayah.ayahKey)}
           className="text-muted"
         >
-          <i className={`ss-icon ${playing ? 'ss-pause' : 'ss-play'}`} />
+          <i className={`ss-icon ${playing ? 'ss-pause' : 'ss-play'} vertical-align-middle`} />{' '}
           <LocaleFormattedMessage
             id={playing ? 'actions.pause' : 'actions.play'}
             defaultMessage={playing ? 'Pause' : 'Play'}
@@ -223,7 +219,8 @@ export default class Ayah extends Component {
           onClick={() => bookmarkActions.removeBookmark(ayah.ayahKey)}
           className="text-muted"
         >
-          <strong><i className="ss-icon ss-bookmark" />
+          <strong>
+            <i className="ss-icon ss-bookmark vertical-align-middle" />{' '}
             <LocaleFormattedMessage
               id="ayah.bookmarked"
               defaultMessage="Bookmarked"
@@ -239,7 +236,7 @@ export default class Ayah extends Component {
         onClick={() => bookmarkActions.addBookmark(ayah.ayahKey)}
         className="text-muted"
       >
-        <i className="ss-icon ss-bookmark" />
+        <i className="ss-icon ss-bookmark vertical-align-middle" />{' '}
         <LocaleFormattedMessage
           id="ayah.bookmark"
           defaultMessage="Bookmark"

diff --git a/src/components/ContentDropdown/index.js b/src/components/ContentDropdown/index.js
@@ -1,9 +1,9 @@
 import React, { Component, PropTypes } from 'react';
 
+import ButtonToolbar from 'react-bootstrap/lib/ButtonToolbar';
 import DropdownButton from 'react-bootstrap/lib/DropdownButton';
 import MenuItem from 'react-bootstrap/lib/MenuItem';
 import LocaleFormattedMessage from 'components/LocaleFormattedMessage';
-import { optionsType } from 'types';
 
 const style = require('./style.scss');
 
@@ -450,26 +450,18 @@ export const slugs = [
 export default class ContentDropdown extends Component {
   static propTypes = {
     onOptionChange: PropTypes.func.isRequired,
-    options: optionsType.isRequired,
+    content: PropTypes.arrayOf(PropTypes.number).isRequired,
     className: PropTypes.string
   };
 
-  static defaultProps = {
-    className: 'col-md-3'
-  }
-
-  shouldComponentUpdate(nextProps) {
-    return this.props.options !== nextProps.options;
-  }
-
   handleRemoveContent = () => {
     const { onOptionChange } = this.props;
 
     onOptionChange({ content: [] });
   }
 
   handleOptionSelected(id) {
-    const { onOptionChange, options: { content } } = this.props;
+    const { onOptionChange, content } = this.props;
 
     if (content.find(option => option === id)) {
       onOptionChange({ content: content.filter(option => option !== id) });
@@ -479,7 +471,7 @@ export default class ContentDropdown extends Component {
   }
 
   renderItems(items) {
-    const { options: { content } } = this.props;
+    const { content } = this.props;
 
     return items.map((slug) => {
       const checked = content.find(option => option === slug.id);
@@ -515,29 +507,34 @@ export default class ContentDropdown extends Component {
   }
 
   render() {
-    const { className, options: { content } } = this.props;
+    const { className, content } = this.props;
+    const title = slugs.filter(slug => content.includes(slug.id)).map(slug => slug.name).join(', ');
 
     return (
-      <DropdownButton
-        className={`dropdown ${className} ${style.dropdown}`}
-        title={<LocaleFormattedMessage id="setting.translations.title" defaultMessage="Translations" />}
-      >
-        {
-          content.length &&
-            <MenuItem onClick={this.handleRemoveContent}>
-              <LocaleFormattedMessage id="setting.translations.removeAll" defaultMessage="Remove all" />
-            </MenuItem>
-        }
-        <MenuItem header>
-          <LocaleFormattedMessage id="setting.translations.english" defaultMessage="English" />
-        </MenuItem>
-        {this.renderEnglishList()}
-        <MenuItem divider />
-        <MenuItem header>
-          <LocaleFormattedMessage id="setting.translations.other" defaultMessage="Other Languages" />
-        </MenuItem>
-        {this.renderLanguagesList()}
-      </DropdownButton>
+      <ButtonToolbar>
+        <DropdownButton
+          block
+          id="content-dropdown"
+          className={`dropdown ${className} ${style.dropdown}`}
+          title={title}
+        >
+          {
+            content.length &&
+              <MenuItem onClick={this.handleRemoveContent}>
+                <LocaleFormattedMessage id="setting.translations.removeAll" defaultMessage="Remove all" />
+              </MenuItem>
+          }
+          <MenuItem header>
+            <LocaleFormattedMessage id="setting.translations.english" defaultMessage="English" />
+          </MenuItem>
+          {this.renderEnglishList()}
+          <MenuItem divider />
+          <MenuItem header>
+            <LocaleFormattedMessage id="setting.translations.other" defaultMessage="Other Languages" />
+          </MenuItem>
+          {this.renderLanguagesList()}
+        </DropdownButton>
+      </ButtonToolbar>
     );
   }
 }
diff --git a/src/components/ContentDropdown/spec.js b/src/components/ContentDropdown/spec.js
@@ -12,7 +12,7 @@ describe('<ContentDropdown />', () => {
     onOptionChange = sinon.stub();
     wrapper = mountWithIntl(
       <ContentDropdown
-        options={{ content: [defaultOption] }}
+        content={[defaultOption]}
         onOptionChange={onOptionChange}
       />
     );

diff --git a/src/components/Copy/index.js b/src/components/Copy/index.js
@@ -28,7 +28,7 @@ export default class Copy extends Component {
         className={!isCopied && 'text-muted'}
         data-metrics-event-name="Ayah:Copy"
       >
-        <i className="ss-icon ss-attach" />
+        <i className="ss-icon ss-attach vertical-align-middle" />{' '}
         <LocaleFormattedMessage
           id={isCopied ? 'actions.copied' : 'actions.copy'}
           defaultMessage={isCopied ? 'Copied!' : 'Copy'}

diff --git a/src/components/FontSizeDropdown/index.js b/src/components/FontSizeDropdown/index.js
@@ -6,18 +6,19 @@ import Col from 'react-bootstrap/lib/Col';
 
 import LocaleFormattedMessage from 'components/LocaleFormattedMessage';
 
-import { optionsType } from 'types';
-
 const style = require('./style.scss');
 
 export default class FontSizeDropdown extends Component {
   static propTypes = {
     onOptionChange: PropTypes.func,
-    options: optionsType
+    fontSize: PropTypes.shape({
+      arabic: PropTypes.number,
+      translation: PropTypes.number
+    }).isRequired
   }
 
   handleOptionSelected = (type, direction) => {
-    const { onOptionChange, options: { fontSize } } = this.props;
+    const { onOptionChange, fontSize } = this.props;
     const changeFactor = {
       translation: 0.5,
       arabic: 0.5
@@ -94,15 +95,17 @@ export default class FontSizeDropdown extends Component {
 
   render() {
     return (
-      <OverlayTrigger trigger="click" placement="bottom" overlay={this.renderPopup()} rootClose>
-        <a
-          tabIndex="-1"
-          className="text-color"
-          data-metrics-event-name="FontSizeDropdown"
-        >
-          <LocaleFormattedMessage id="setting.fontSize" defaultMessage="Font size" />
-        </a>
-      </OverlayTrigger>
+      <li className={style.link}>
+        <OverlayTrigger trigger="click" placement="bottom" overlay={this.renderPopup()} rootClose>
+          <a
+            tabIndex="-1"
+            data-metrics-event-name="FontSizeDropdown"
+          >
+            <i className="ss-icon ss-font vertical-align-middle" />
+            {' '}<LocaleFormattedMessage id="setting.fontSize" defaultMessage="Font Size" className="visible-xs-inline-block" />
+          </a>
+        </OverlayTrigger>
+      </li>
     );
   }
 }
diff --git a/src/components/FontSizeDropdown/style.scss b/src/components/FontSizeDropdown/style.scss
@@ -1,6 +1,6 @@
 @import '../../styles/variables.scss';
 
-:local .popover{
+.popover{
   :global(.popover-title){
     font-family: $font-montserrat;
     text-transform: uppercase;
@@ -16,3 +16,9 @@
     }
   }
 }
+
+.link{
+  position: relative;
+  display: block;
+  cursor: pointer;
+}
diff --git a/src/components/Footer/index.js b/src/components/Footer/index.js
@@ -5,7 +5,6 @@ import Grid from 'react-bootstrap/lib/Grid';
 import Col from 'react-bootstrap/lib/Col';
 
 import LocaleFormattedMessage from 'components/LocaleFormattedMessage';
-import LocaleSwitcher from 'components/LocaleSwitcher';
 
 const styles = require('./style.scss');
 
@@ -144,7 +143,6 @@ const Footer = () => (
             </p>
 
             <div className={styles.list}>
-              <LocaleSwitcher />
               <p className="monserrat">
                 <LocaleFormattedMessage
                   id="nav.aboutQuranProject"