Skip to content

Commit

Permalink
refactor(rust): Remove old streaming flag if we're going into new str…
Browse files Browse the repository at this point in the history
…eaming (pola-rs#18438)
  • Loading branch information
orlp authored and r-brink committed Aug 29, 2024
1 parent ff958af commit 87ba4bd
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
1 change: 1 addition & 0 deletions crates/polars-lazy/src/frame/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,7 @@ impl LazyFrame {
// if it fails in a todo!() error if auto_new_streaming is set.
let mut new_stream_lazy = self.clone();
new_stream_lazy.opt_state |= OptFlags::NEW_STREAMING;
new_stream_lazy.opt_state &= !OptFlags::STREAMING;
let mut alp_plan = new_stream_lazy.to_alp_optimized()?;
let stream_lp_top = alp_plan.lp_arena.add(IR::Sink {
input: alp_plan.lp_top,
Expand Down
11 changes: 10 additions & 1 deletion crates/polars-stream/src/skeleton.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
use polars_core::prelude::*;
use polars_core::POOL;
use polars_expr::planner::{create_physical_expr, get_expr_depth_limit, ExpressionConversionState};
use polars_plan::plans::{Context, IR};
use polars_plan::plans::{Context, IRPlan, IR};
use polars_plan::prelude::expr_ir::ExprIR;
use polars_plan::prelude::AExpr;
use polars_utils::arena::{Arena, Node};
Expand All @@ -17,6 +17,15 @@ pub fn run_query(
mut ir_arena: Arena<IR>,
expr_arena: &mut Arena<AExpr>,
) -> PolarsResult<DataFrame> {
if let Ok(visual_path) = std::env::var("POLARS_VISUALIZE_IR") {
let plan = IRPlan {
lp_top: node,
lp_arena: ir_arena.clone(),
expr_arena: expr_arena.clone(),
};
let visualization = plan.display_dot().to_string();
std::fs::write(visual_path, visualization).unwrap();
}
let mut phys_sm = SlotMap::with_capacity_and_key(ir_arena.len());
let root =
crate::physical_plan::build_physical_plan(node, &mut ir_arena, expr_arena, &mut phys_sm)?;
Expand Down

0 comments on commit 87ba4bd

Please sign in to comment.