highlight Rd code blocks according to their language (new take) #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relies on div with classes introduced by r-lib/roxygen2#1229 -- is that a bad idea? Should the docs state that somehow? |
maelle
commented
Jun 18, 2021
hadley
reviewed
Aug 31, 2021
maelle
commented
Sep 1, 2021
|
Noting here that the snapshot depends on the Pandoc version 😩 Locally I have Pandoc 2.11.4 and got <body>
<div class="ref-section">
<div class="sourceCode yaml">
<pre>
<code><span id="cb1-1"><a href="#cb1-1" aria-hidden="true" tabindex="-1"></a></span>
<span id="cb1-2"><a href="#cb1-2" aria-hidden="true" tabindex="-1"></a><span class="at"> </span><span class="fu">url</span><span class="kw">:</span><span class="at"> https://pkgdown.r-lib.org/</span></span>
<span id="cb1-3"><a href="#cb1-3" aria-hidden="true" tabindex="-1"></a></span>
<span id="cb1-4"><a href="#cb1-4" aria-hidden="true" tabindex="-1"></a><span class="at"> </span></span></code>
</pre>
</div>
</div>
</body> |
maelle
commented
Sep 1, 2021
Conflicts: NEWS.md R/html-tweak.R tests/testthat/_snaps/html-tweak.md tests/testthat/test-html-tweak.R tests/testthat/test-template-content.R
hadley
reviewed
Oct 13, 2021
| @@ -0,0 +1,64 @@ | |||
| # Syntax highlight for preformatted code blocks | |||
| tweak_reference_highlighting <- function(html) { | |||
There was a problem hiding this comment.
@maelle I ended up basically re-writing this, but it made me fully understand why it was so complicated 😄 It's a bit easier to test now because I've separated the "finding" from the "modifying" code, and tried to document what I learned in the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1690
Fix #1692
TODOs