Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape "%" etc. in URLs #1416

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Conversation

HenningLorenzen-ext-bayer
Copy link
Contributor

@HenningLorenzen-ext-bayer HenningLorenzen-ext-bayer commented Aug 10, 2022

Fixes #1415

@HenningLorenzen-ext-bayer HenningLorenzen-ext-bayer changed the title fix: escape "%" etc. in package_seealso_urls() Escape "%" etc. in URLs Aug 10, 2022
@HenningLorenzen-ext-bayer HenningLorenzen-ext-bayer marked this pull request as ready for review August 10, 2022 16:01
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

@hadley hadley merged commit 335448d into r-lib:main Nov 16, 2023
12 checks passed
@hadley
Copy link
Member

hadley commented Nov 16, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL escape characters from package DESCRIPTION are not escaped for .Rd
2 participants