4.x: remove availability of CQv1 #10656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The forced push is a rebase. |
essen
force-pushed
the
loic-remove-cqv1-option
branch
from
841774b
to
ef45f34
Compare
michaelklishin
changed the title
essen
force-pushed
the
loic-remove-cqv1-option
branch
from
0b1740c
to
2723dad
Compare
This comment was marked as outdated.
This comment was marked as outdated.
We reject CQv1 in rabbit.schema as well. Most of the v1 code is still around as it is needed for conversion to v2. It will be removed at a later time when conversion is no longer supported. We don't shard the CQ property suite anymore: there's only 1 case remaining.
essen
force-pushed
the
loic-remove-cqv1-option
branch
from
2723dad
to
ecf4600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the v1 code is still around as it is needed for conversion to v2. It will be removed at a later time when conversion is no longer supported.
A few notes:
classic_queue_default_version: currently it remains but is unused. We validate the value and if it selects v1 we abort with an informative errorx-queue-versionandx-queue-moderemain. We can't really remove them. They are ignoredType of Changes