Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend common metadata by keywords #1187

Closed
m-mohr opened this issue Sep 9, 2022 · 10 comments · Fixed by #1227
Closed

Extend common metadata by keywords #1187

m-mohr opened this issue Sep 9, 2022 · 10 comments · Fixed by #1227
Milestone

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Sep 9, 2022

We've already made license and providers common metadata, but there are a couple more things that we could add there so that they get more "common".

@m-mohr m-mohr added this to the 1.1 milestone Sep 9, 2022
@KennSmithDS
Copy link

@m-mohr emphasizing from prior discussion on Slack that Common Metadata get applied to Catalog objects as well, particularly keywords, created, updated.

@emmanuelmathot
Copy link
Collaborator

emmanuelmathot commented Sep 16, 2022

Totally agree with all the propositions. We could make separate PRs to propose and decide for each of them? I already did the work for keywords in this extension proposal: https://github.com/stac-extensions/subjects

@m-mohr
Copy link
Collaborator Author

m-mohr commented Sep 16, 2022

Yes, we can sure go on a 1:1 basis. Keywords is meant to stay free-form without vocabulary though so I still think there's value in the subjects extension (although potentially aligned with OGC APIs).

For OGC APIs we also discussed (and agreed on) having created and updated in links as they don't have assets.

@p1d1d1
Copy link

p1d1d1 commented Oct 18, 2022

could you please consider this? #1190

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jan 5, 2023

keywords: Wait for #1199 to be merged, then we can PR it into common metadata and directly remove keywords from the collection schema, too.

language is now part of the langauge extension: https://github.com/stac-extensions/language

@m-mohr m-mohr self-assigned this Jan 5, 2023
@m-mohr m-mohr changed the title Extend common metadata Extend common metadata by keywords Apr 4, 2023
@PowerChell
Copy link

The scope of this issue has been updated to the remaining issue: adding keywords to common metadata.

Update determined during STAC Working Session April 4, 2023.

@emmanuelmathot
Copy link
Collaborator

keywords: Wait for #1199 to be merged, then we can PR it into common metadata and directly remove keywords from the collection schema, too.

#1199 is not a PR. I dont find one that covers the keywords integration in common metadata

@m-mohr
Copy link
Collaborator Author

m-mohr commented Apr 13, 2023

Yeah, the reference is off. I need to create a new PR for keywords.

@emmanuelmathot
Copy link
Collaborator

ok. I can help with that if needed.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Apr 13, 2023

@emmanuelmathot Great, happy to review the PR.

I guess it's relatively simple, just add keywords to the Basics category: https://github.com/radiantearth/stac-spec/blob/master/item-spec/common-metadata.md#basics
Update JSON Schema (move from Collection to common metadata and reference it from the Collection).

@m-mohr m-mohr removed their assignment Apr 13, 2023
@m-mohr m-mohr linked a pull request Apr 29, 2023 that will close this issue
4 tasks
@m-mohr m-mohr closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants