Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create frontend GitHub actions workflows, added new frontend template #118

Merged
merged 10 commits into from
Mar 29, 2024

Conversation

rak3rman
Copy link
Member

@rak3rman rak3rman commented Mar 28, 2024

Refactored existing Github Actions workflows to make the purpose of each workflow more clear. Added additional workflows and utils to support stand up and teardown of staging envs for the next frontend. Completely wiped the existing frontend in favor of a next.js template that works nicely with Cloudflare Pages. Closes #96.

@rak3rman rak3rman self-assigned this Mar 28, 2024
@rak3rman rak3rman linked an issue Mar 28, 2024 that may be closed by this pull request
5 tasks
Copy link

github-actions bot commented Mar 28, 2024

Pull Request Smart Comments
Assignee(s): Mark tasks as they are completed. Code Reviewer(s): Ensure all tasks are complete and follow best standards before approving.

  • Assigned at least one (1+) experienced code reviewer and notified them requesting a review
  • Assigned all contributors as assignees
  • Assigned relevant labels that are a subset or related to the parent issue's labels
  • Checked that PR description contains a quick summary of work accomplished and uses issue closing words
  • Checked that completed tasks in related issue(s) are marked accordingly
  • Checked that PR title is descriptive and follows commit message semantics

@rak3rman rak3rman force-pushed the 96-create-frontend-github-actions-workflows branch from 51927cf to f50ff16 Compare March 28, 2024 06:01
@rak3rman rak3rman changed the title feat: create frontend GitHub actions workflows feat: create frontend GitHub actions workflows, added new frontend template Mar 28, 2024
@rak3rman rak3rman added frontend Related to the next frontend devex Developer experience; makes it easier for contributors to write code labels Mar 28, 2024
@rak3rman rak3rman marked this pull request as ready for review March 28, 2024 06:07
@rak3rman
Copy link
Member Author

Evidence of the Staging Teardown script working on Github Actions runners: https://github.com/radicalplatforms/shafa/actions/runs/8463035681
Didn't end up testing the Production Deploy script since, well, it deploys to production. I feel confident in the code as it is similar to the Next Integration script.

@rak3rman rak3rman removed the request for review from SengdowJones March 29, 2024 03:56
Copy link
Contributor

@vincentdo1 vincentdo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflows look good to me. Question on if we want to initialize a templated frontend structure or have that in an upcoming PR.

next/src/app/api/hello/route.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@vincentdo1 vincentdo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L G T M

@rak3rman rak3rman merged commit 7386d5e into main Mar 29, 2024
9 checks passed
@rak3rman rak3rman deleted the 96-create-frontend-github-actions-workflows branch March 29, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex Developer experience; makes it easier for contributors to write code frontend Related to the next frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create next (frontend) Github Actions workflows
2 participants