Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better mask validation for broadcastable arrays #115

Merged
merged 3 commits into from
Jul 24, 2014

Conversation

keflavich
Copy link
Contributor

Broadcastable masks, e.g. 2D masks, are valid and should work, but right now the validation scheme stops that. I don't know how to do this appropriately yet, but I've asked on stackoverflow

@keflavich keflavich added the bug label Jul 15, 2014
@ChrisBeaumont
Copy link

I suggested one approach on SO, which lets you test if two shapes are broadcastable without allocating memory for an array to hold both shapes. I'm not sure if thats the kind of laziness you are after?

@keflavich
Copy link
Contributor Author

Yes, it is. That's a great solution; I'll try to test it out. I'm surprised there's not something easier.

@ChrisBeaumont
Copy link

Me neither, I've looked for the same thing in the past

@keflavich
Copy link
Contributor Author

@astrofrog I left this one off the list, but I think it's good to go too.

@astrofrog
Copy link
Member

👍

@astrofrog
Copy link
Member

@keflavich - you're going to kill me, but could you add changelog entries for all the PRs you merged today? :)

keflavich added a commit that referenced this pull request Jul 24, 2014
Need better mask validation for broadcastable arrays
@keflavich keflavich merged commit 0dbc29f into radio-astro-tools:master Jul 24, 2014
@keflavich keflavich deleted the verify-masks branch July 24, 2014 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants