Updated .travis.yml to use ci-helpers #258
Conversation
astrofrog
force-pushed
the
use-ci-helpers
branch
from
024f162
to
da354f7
Compare
…still some issues on Python 3 with Numpy 1.10
astrofrog
force-pushed
the
use-ci-helpers
branch
from
bf83024
to
0d3ceec
Compare
…other skip-related cleanup.
astrofrog
force-pushed
the
use-ci-helpers
branch
from
3b9f258
to
e48cad5
Compare
|
Still investigating memory issues - I think there is a memory leak in astropy.wcs |
astrofrog
force-pushed
the
use-ci-helpers
branch
2 times, most recently
from
0687c77
to
b8a7ab7
Compare
…use there are some memory leaks in Astropy that otherwise cause the RAM usage to increase steadily over time
astrofrog
force-pushed
the
use-ci-helpers
branch
from
b8a7ab7
to
26cb4ba
Compare
|
@keflavich - this is ready for review! |
|
Note that some of the configurations still take 10-20 minutes to run (as was the case prior to this PR), which is what led me to investigate this memory leak in Astropy: astropy/astropy#4441 - but I just realized that actually the builds with Astropy dev are already a lot faster, so I think this is just an issue with the Astropy stable release. I'm not 100% sure what was fixed since 1.1 that would cause this though. Anyway, I'll look into it separately. |
| if cube.size < threshold: # smallish | ||
|
|
||
| # TODO: make this into a proper configuration item | ||
| # TODO: make threshold depend on memory? |
There was a problem hiding this comment.
I think it's reasonable to not make the threshold depend on memory, but make this a configuration item. Even with lots of memory, operations on huge cubes can take forever, and I think it's better to be up front about that.
There was a problem hiding this comment.
...oh, the note was from me. Well, I can argue with myself!
There was a problem hiding this comment.
I've opened an issue for the config item: #261
|
Looks great. I only have one comment that warrants change (the |
|
@keflavich - I addressed your comment and Travis is still passing (and I think the coverage failure is just due to random fluctuations) so I'll go ahead and merge this. |
Updated .travis.yml to use ci-helpers
No description provided.