Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask out planes with NaN beams #298

Merged
merged 7 commits into from
May 18, 2016

Conversation

keflavich
Copy link
Contributor

No description provided.

@keflavich
Copy link
Contributor Author

keflavich commented May 13, 2016

I have a problem here: Why did this fail:
https://github.com/keflavich/spectral-cube/blob/426400624cf949aea8053ae7232265d1b07c4348/spectral_cube/spectral_cube.py#L2450

but this worked:
https://github.com/keflavich/spectral-cube/blob/master/spectral_cube/tests/test_masks.py#L398

as far as I can tell, they're the same code, but the first instance resulted in deep failures while the second has always worked.

EDIT:
specifically, the failure mode looks like this:

    def _include(self, data=None, wcs=None, view=()):
>       result_mask = self._mask[view]
E       IndexError: index 1 is out of bounds for axis 2 with size 1

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 72.541% when pulling 4264006 on keflavich:check_bad_beams into c10395f on radio-astro-tools:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 72.695% when pulling f518421 on keflavich:check_bad_beams into c10395f on radio-astro-tools:master.

@keflavich
Copy link
Contributor Author

@e-koch @low-sky @astrofrog any of you up for reviewing this?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 72.695% when pulling 5c3579b on keflavich:check_bad_beams into c10395f on radio-astro-tools:master.

@keflavich keflavich merged commit 529eef0 into radio-astro-tools:master May 18, 2016
@keflavich keflavich deleted the check_bad_beams branch May 18, 2016 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants