Replace distutils.LooseVersion with packaging.version #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
force-pushed
the
no-loose-version
branch
from
e3cbfed
to
22acc38
Compare
This is for Python 3.12 compatibility
olebole
force-pushed
the
no-loose-version
branch
from
22acc38
to
1fab31a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #901 +/- ##
==========================================
- Coverage 79.95% 79.94% -0.02%
==========================================
Files 24 24
Lines 6016 6013 -3
==========================================
- Hits 4810 4807 -3
Misses 1206 1206 ☔ View full report in Codecov by Sentry. |
keflavich
approved these changes
Feb 8, 2024
keflavich
reviewed
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.12, distutils does no longer exist. In spectral-cube it is used only for version comparison. This PR replaces it with packaging.version.parse resp. packaging.version.Version. On places where LooseVersion is unused, the import is just removed.
This should make the package compatible to Python 3.12; at least the tests that we run during the Debian build pass.