Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline script linting #147

Merged
merged 18 commits into from
Jan 5, 2021
Merged

Pipeline script linting #147

merged 18 commits into from
Jan 5, 2021

Commits on Dec 9, 2020

  1. refactor(config): raise ConfigError if error reading config

    @nritsche
    nritsche committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    1d7cc32 View commit details
    Browse the repository at this point in the history

  2. refactor(config): raise ConfigError if proptype fails

    @nritsche
    nritsche committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    e979611 View commit details
    Browse the repository at this point in the history

  3. refactor(pipeline): raise PipelineConfigError if error in task config

    @nritsche
    nritsche committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    45afc43 View commit details
    Browse the repository at this point in the history

  4. feat(pipeline): task config in/out/requires validation 

    Check if every in/requires has a corresponding out in the pipeline
config.
    @nritsche
    nritsche committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    f31cc06 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. feat(runner): config file linting 

    Add lint command as well as --lint for the queue command.
    @nritsche
    nritsche committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    ef6532f View commit details
    Browse the repository at this point in the history

  2. feat(pipeline): raise PipelineError if file name can't be understood

    @nritsche
    nritsche committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    5975824 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. test(lint): add tests for the script's new lint command

    @nritsche
    nritsche committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    f8dbaab View commit details
    Browse the repository at this point in the history

  2. docs(pipeline): disable example of in without out

    @nritsche
    nritsche committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    c53e3ae View commit details
    Browse the repository at this point in the history

  3. fix(pipeline): in/out/requires linting doesn't work in py2

    @nritsche
    nritsche committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    c39d0de View commit details
    Browse the repository at this point in the history

  4. fix(pipeline): in/out/require linting depends on order of tasks

    @nritsche
    nritsche committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    10ca23f View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. typo

    @nritsche
    nritsche committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    c22f48c View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. use the venv specified in cluster config for linting

    @nritsche
    nritsche committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    d9ceb90 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. linter: print line numbers 

    - merge pipeline.PipelineConfigError and config.CaputConfigError
- add line number and  file name to exception
- check for unused keys (ignore the ones added by pipeline setup, not by
user)
- add (very stupid) indentation to linter output
    @nritsche
    nritsche committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    ffdc451 View commit details
    Browse the repository at this point in the history

  2. refactor(pipeline): make _validate_task static

    @nritsche
    nritsche committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    743bf1a View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. fix tests

    @nritsche
    nritsche committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    2fccab9 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. ignore __file__ in logging config

    @nritsche
    nritsche committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    e555da3 View commit details
    Browse the repository at this point in the history

  2. pipeline.Manager: don't allow DEBUG logging when linting

    @nritsche
    nritsche committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    93fa7ec View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Merge branch 'master' of github.com:radiocosmology/caput into rn/scri… 

    …ptlinter
    @nritsche
    nritsche committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    aeb7643 View commit details
    Browse the repository at this point in the history