Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter #160

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Fix linter #160

merged 2 commits into from
Jan 20, 2021

Conversation

nritsche
Copy link
Contributor

Closes #159

Copy link
Contributor

@jrs65 jrs65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This all looks like it should work fine to me now. However, I think the use of pathlib in here could do with straightening out. There's a bunch of places where pathlib methods are being called like functions, e.g. Path.is_absolute(f) rather than f.is_absolute(), and where Path.joinpath(a, b) is being used instead of a / b. I've made a few suggestions, but they're not exhaustive so you'll probably need to look through more carefully.

caput/scripts/runner.py Outdated Show resolved Hide resolved
caput/scripts/runner.py Outdated Show resolved Hide resolved
caput/scripts/runner.py Outdated Show resolved Hide resolved
caput/scripts/runner.py Outdated Show resolved Hide resolved
caput/scripts/runner.py Outdated Show resolved Hide resolved
caput/scripts/runner.py Show resolved Hide resolved
@nritsche nritsche merged commit f7e2334 into master Jan 20, 2021
@nritsche nritsche deleted the rn/linterfix branch January 20, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting issues
2 participants