build: update versioneer #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we need versioneer at least 0.19 to have get_cmdclass with an argument See: python-versioneer/python-versioneer#161 (comment)
nritsche
requested changes
Apr 13, 2021
| @@ -116,7 +116,7 @@ def versions_from_parentdir(parentdir_prefix, root, verbose): | |||
| """ | |||
| rootdirs = [] | |||
|
|
|||
| for _ in range(3): | |||
There was a problem hiding this comment.
i is still not used here, so this will trigger some linter warnings.
There was a problem hiding this comment.
I saw that! I want to ignore the linter warnings for this file, but would you prefer for me to modify _version.py?
|
This pull request introduces 1 alert when merging b5a98d5 into fd12caf - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: python-versioneer/python-versioneer#161 (comment)