Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mpiarray): only give warning when compression is disabled by the pipeline #202

Merged
merged 1 commit into from
Jul 11, 2022
Merged

fix(mpiarray): only give warning when compression is disabled by the pipeline #202

merged 1 commit into from
Jul 11, 2022

Conversation

jrs65
Copy link
Contributor

@jrs65 jrs65 commented Jun 30, 2022 •
edited
Loading

This PR cleans up the logic around how the writing code decides whether to use collective IO or not, and then only warns for unexpected cases.

@jrs65 jrs65 requested a review from tristpinsm June 30, 2022 16:45
tristpinsm
tristpinsm approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@tristpinsm tristpinsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is also a lot easier to understand now

@jrs65 jrs65 merged commit ffd3563 into master Jul 11, 2022
@jrs65 jrs65 deleted the fix-io-error-message branch July 11, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristpinsm tristpinsm tristpinsm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrs65 @tristpinsm