Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redistribute copy if using a single mpi process #256

Merged
merged 1 commit into from
May 10, 2024

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Oct 30, 2023

This is relevant because of the check for available memory. If we are on a single node, we don't need to make a new array, so this was effectively limiting users to mpiarrays that were < ~0.4 of the available memory (which could be problematic in a notebook, for example)

@ljgray ljgray force-pushed the ljg/redistribute-mem-check branch 2 times, most recently from bd36e5d to fe0d207 Compare October 30, 2023 22:10
@ljgray ljgray marked this pull request as ready for review October 30, 2023 22:17
@ljgray ljgray force-pushed the ljg/redistribute-mem-check branch 6 times, most recently from a2f8ba9 to 58e285f Compare October 30, 2023 23:48
@ljgray ljgray force-pushed the ljg/redistribute-mem-check branch from c5a8f29 to def663a Compare May 1, 2024 23:12
@ljgray ljgray requested a review from ketiltrout May 3, 2024 20:46
Copy link
Member

@ketiltrout ketiltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming everything from line 763 onwards is just left-shifted one indent level. A cursory look seems like that's true.

Otherwise, this looks fine.

caput/mpiarray.py Outdated Show resolved Hide resolved
@ljgray ljgray force-pushed the ljg/redistribute-mem-check branch from def663a to 99b47a4 Compare May 10, 2024 00:42
@ljgray ljgray merged commit 6c2ba2b into master May 10, 2024
5 checks passed
@ljgray ljgray deleted the ljg/redistribute-mem-check branch May 10, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants