Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MakeSiderealDayStream): a new task to simulate a specific LSD #113

Merged
merged 2 commits into from
Dec 1, 2020
Merged

feat(MakeSiderealDayStream): a new task to simulate a specific LSD #113

merged 2 commits into from
Dec 1, 2020

Conversation

jrs65
Copy link
Contributor

@jrs65 jrs65 commented Oct 29, 2020

No description provided.

@jrs65 jrs65 requested a review from cahofer October 29, 2020 05:32
cahofer
cahofer approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@cahofer cahofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test the task? I don't see anything obvious that needs change. The f-string syntax is new to me. Is that new python 3 standard?

draco/synthesis/stream.py Show resolved Hide resolved
@jrs65
Copy link
Contributor Author

jrs65 commented Nov 25, 2020

I have indeed tested it. Thanks for the review!!

@jrs65 jrs65 merged commit fa7d20a into master Dec 1, 2020
@jrs65 jrs65 deleted the make-sidereal-day branch December 1, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahofer cahofer cahofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrs65 @cahofer