fix(ringmapmaker): MPI calls could get out of sync #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssiegelx
approved these changes
Jun 19, 2021
This fixes a nasty bug where MPI calls could get out of sync when using `DeconvolveAnalyticalBeam` in a case where different ranks have differing numbers of frequencies. To rectify this it refactors the code such that the beam_mmodes are generate for all frequencies at once which will prevent the bug from resurfacing in newer implementations.
This allows using a grid beam with a different grid to the underlying data. This can be applied as an external beam when deconvolving ringmaps provided it is higher resolution than the data.
A bug meant that the high-m modes could potentially be left unset as the array was not filled at creation, and the highest modes might not actually be set.
Rename the parameter for consistency
|
@ssiegelx I think this is done. I added a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nasty bug where MPI calls could get out of sync when using
DeconvolveAnalyticalBeamin a case where different ranks havediffering numbers of frequencies. To rectify this it refactors the code
such that the beam_mmodes are generate for all frequencies at once which
will prevent the bug from resurfacing in newer implementations.