Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stacking/beamform bug fixes #147

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Stacking/beamform bug fixes #147

merged 4 commits into from
Jul 27, 2021

Conversation

jrs65
Copy link
Contributor

@jrs65 jrs65 commented Jul 21, 2021

  • fix(RingMapBeamform): incorrect positions when ringmap has a reduced span of ZA
  • fix(mockcatalog): NaN's produced if selection func zero for a z slice
  • fix: ensure attributes are copied over during container creation
  • refactor: use a consistent scheme for matching catalog and data coordinate epochs

@jrs65
fix(RingMapBeamform): incorrect positions when ringmap has a reduced …
1470e9f 
…span of ZA
@jrs65
fix(mockcatalog): NaN's produced if selection func zero for a z slice
5500c90
@jrs65
fix: ensure attributes are copied over during container creation
29ce37f
@jrs65
refactor: use a consistent scheme for matching catalog and data coord…
ccaac00 
…inate epochs

This refactors the code such that `HealpixBeamForm`, `RingMapBeamform`
and `RingMapStack2D` all use a common scheme for determining what the
catalog data/epoch.

Additionally this factors out common functionality between
`RingMapBeamform` and `RingMapStack2D` this is equivalent, which also
fixes the bug when a ringmap of not the full ZA range is used in
`RingMapStack2D`.
sjforeman
sjforeman approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@sjforeman sjforeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great to me! I have a few related changes that will go on top of these, but I'll make a separate PR for those once this has been merged

@jrs65 jrs65 merged commit 9be52f2 into master Jul 27, 2021
@jrs65 jrs65 deleted the jrs/stacking-fixes branch July 27, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjforeman sjforeman sjforeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrs65 @sjforeman