Task to add eBOSS-like redshift errors to catalog #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set std of added errors
This code is taken from Seth's routines that were previously in a ch_pipeline pull request, but has been mildly refactored to put it into a separate task.
jrs65
requested changes
Jul 30, 2021
ssiegelx
approved these changes
Jul 30, 2021
jrs65
approved these changes
Aug 2, 2021
Co-authored-by: Richard Shaw <richard@phas.ubc.ca>
Co-authored-by: Richard Shaw <richard@phas.ubc.ca>
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors Seth's eBOSS redshift error code into a separate task, and implements a few other minor tweaks.