Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(invert_no_zero): issue when operating on MPIArrays #178

Merged
merged 2 commits into from
Jun 9, 2022
Merged

fix(invert_no_zero): issue when operating on MPIArrays #178

merged 2 commits into from
Jun 9, 2022

Conversation

jrs65
Copy link
Contributor

@jrs65 jrs65 commented Jun 3, 2022 •
edited
Loading

I think the fix turns out to be trivial in here, as all the new MPIArray code means that .empty_like does exactly what you would want it to.

@jrs65 jrs65 requested a review from tristpinsm June 3, 2022 22:37
tristpinsm
tristpinsm approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@tristpinsm tristpinsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good that there is a simple solution!

@jrs65
Copy link
Contributor Author

jrs65 commented Jun 3, 2022

Actually I don't think I want a ravel in there as it's more likely to make a copy.

@jrs65 jrs65 force-pushed the fix-invert-no-zero-mpiarray branch from f57ba82 to 5630365 Compare June 9, 2022 18:16
@jrs65 jrs65 merged commit b0347cb into master Jun 9, 2022
@jrs65 jrs65 deleted the fix-invert-no-zero-mpiarray branch June 9, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristpinsm tristpinsm tristpinsm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrs65 @tristpinsm