Fix Gibbs sampler bug and add initial_amplitude parameter, and fix misc. MPIArray warnings #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has turned into a Frankenstein of various edits, but they are all relatively minor:
Fix a few MPIArray warnings I've found in various tasks.
Fix the following bug in
DelaySpectrumEstimatorBase
: if the input container has a large number of "baselines" with zero data or weights, such that there is an MPI rank that only contains these baselines, the routine that initializes the random number generator will never be called on this rank, becauseself.rng
is only called in the argument ofdelay_spectrum_gibbs()
in the main loop:draco/draco/analysis/delay.py
Lines 671 to 716 in 1603553
rng = self.rng
.Allow the user to specify the amplitude of the initial power spectrum guess in
DelaySpectrumEstimator
andDelaySpectrumEstimatorBase
.