Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misc): Log MPI check as successful only after all ranks complete #212

Merged
merged 1 commit into from
Nov 23, 2022
Merged

fix(misc): Log MPI check as successful only after all ranks complete #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions draco/core/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,6 @@ def setup(self):
success = all([r.get_status() for r in results])

if success:
self.log.debug(
f"Successful after {time.time() - start_time:.1f} seconds"
)
break

time.sleep(5)
Expand All @@ -260,10 +257,13 @@ def setup(self):
self.log.critical("MPI test did not receive the correct data. Aborting...")
comm.Abort()

# This is needed to stop successful processes from finshing if any task
# has failed
# Stop successful processes from finshing if any task has failed
comm.Barrier()

self.log.debug(
f"MPI test successful after {time.time() - start_time:.1f} seconds"
)


class MakeCopy(task.SingleTask):
"""Make a copy of the passed container."""
Expand Down