Mask gain interpolation region after bad calibration #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
changed the title
ljgray
force-pushed
the
ljg/flag_gain_boundaries
branch
3 times, most recently
from
cce56f9
to
a7403f0
Compare
ljgray
force-pushed
the
ljg/flag_gain_boundaries
branch
2 times, most recently
from
407dc7d
to
f6f2983
Compare
sjforeman
requested changes
Feb 24, 2023
ljgray
force-pushed
the
ljg/flag_gain_boundaries
branch
from
55834b2
to
0466d5a
Compare
jrs65
requested changes
Mar 2, 2023
Modify some outdated docs to properly reflect on class functionality. Also, modify the names of three classes to better reflect their use. Original names are alised for compatibility.
Generally just to remove extremely large or small weights which may cause numerical issues.
ljgray
force-pushed
the
ljg/flag_gain_boundaries
branch
from
0466d5a
to
07908b7
Compare
jrs65
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gains are set to 1 when calibration determines some frequencies are bad. The gain interpolation region will also produce junk data, so this is designed to mask that.
This PR has 3 commits:
This task is run for each individual timestream file then masks are combined and applied. It also requires subsequently using
ExpandMaskfromch_pipelineto actually mask the gain interpolation region AFTER individual timestreams have been grouped into a full day.