Timestamp fixes (1/1): Remove some unnecessary time axis copies #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
force-pushed
the
ljg/copy-raw-time-map
branch
from
0317dd8
to
4012c28
Compare
|
this seems fairly innocuous to me, but it's a piece of a larger set of changes for which I don't know the context very well, so not sure it's very useful for me to approve. |
ljgray
force-pushed
the
ljg/copy-raw-time-map
branch
from
4012c28
to
c53251e
Compare
ljgray
changed the title
ljgray
changed the title
ljgray
changed the title
jrs65
approved these changes
Mar 2, 2023
I guess this one probably would be fine to go in now, but I'll just merge all the timestamp stuff together. |
ljgray
force-pushed
the
ljg/copy-raw-time-map
branch
from
518c0c2
to
bae47cc
Compare
Instead, the copy_from parameter will handle directly copying all index_map entries, including the time axis.
ljgray
force-pushed
the
ljg/copy-raw-time-map
branch
from
bae47cc
to
2aeb35f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, the copy_from parameter will handle directly copying all index_map entries, including the time axis.