Only iterate over self.compression if it's a dict #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
force-pushed
the
compression-args
branch
from
ea2ee38
to
7696a99
Compare
jrs65
requested changes
Mar 27, 2023
ljgray
force-pushed
the
compression-args
branch
2 times, most recently
from
0916689
to
5594643
Compare
jrs65
approved these changes
Mar 27, 2023
draco/core/task.py
Outdated
| Otherwise, the default parameters set in the dataset spec are used. | ||
| Note that this will modify these parameters on the container itself, such that | ||
| if it is written out again downstream in the pipeline these will be used. | ||
| If set to `False` (or anything that evaluates to `False`, such as an empty dict), |
There was a problem hiding this comment.
You might want to update the docstring to reflect your last change.
The expected behaviour of the compression argument was to overwrite compression args if a dict with those args was provided, to disable compression if something which evaluates to False was provided, and use the default parameters for the container otherwise. The behaviour previously would instead disable compression if no args were provided.
ljgray
force-pushed
the
compression-args
branch
from
5594643
to
8be5abe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default compression behaviour to use the container compression args. Compression will be disabled if
compression: falseis set, and compression args will be overwritten if a dict is provided in the config.Previously, the default behaviour would disable compression if no arguments were provided