Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y Bug] File picker causes reads of hidden content #1107

Open
5 tasks
reitermb opened this issue Jul 19, 2021 · 6 comments
Open
5 tasks

[A11y Bug] File picker causes reads of hidden content #1107

reitermb opened this issue Jul 19, 2021 · 6 comments
Labels
a11y Accessibility/Section 508 bug dev Refined Ticket has been refined at the backlog refinement V4 - Later Releases

Comments

@reitermb
Copy link

reitermb commented Jul 19, 2021

Description:
The file picker component on the Data Files page reads "no file selected" even when there is a file selected. This is likely a result of the "no file selected" text not getting passed an aria-hidden=true property when it is visibly hidden.

Acceptance Criteria:
Create a list of functional outcomes that must be achieved to complete this issue

  • "No File selected" is not read on file picker components that do have a file
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:
Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

  • Add aria-hidden=true to "no file selected" text element when text element is not visible
  • Run Testing Checklist and confirm all tests pass

Supporting Documentation:
Please include any relevant log snippets/files/screen shots

No.File.Selected.Bug.mov
@valcollignon
Copy link

@reitermb to review this ticket and circle back. per backlog refinement 12.21.21.

@valcollignon
Copy link

@reitermb to review this ticket and circle back. per backlog refinement 12.21.21.

@reitermb have you had a chance to review this? :)

@valcollignon
Copy link

Reviewed briefly in backlog 2.22.22. @reitermb will review.

@andrew-jameson
Copy link
Collaborator

Discussed in backlog refinement 3.1.22 -- @reitermb to still review. He will test to see if applicable.

@reitermb reitermb changed the title [Placeholder] Upload/Download behavior a11y fixes [Bug] Upload/Download behavior fixes Mar 6, 2022
@reitermb reitermb added the bug label Mar 6, 2022
@reitermb
Copy link
Author

reitermb commented Mar 6, 2022

Currently getting a 400 error when I try to submit files so I'm blocked on re-testing the success message element of this, but I have confirmed that the no file selected bug still exists, as well as the download button disappearing when clicked.

Added a video and a little refinement to the ticket

@stevenino stevenino added the Refined Ticket has been refined at the backlog refinement label Apr 26, 2022
@stevenino
Copy link

@reitermb to split out #1107 into required a11y fix and 2nd tix that can be pushed out to v3.1

@reitermb reitermb changed the title [Bug] Upload/Download behavior fixes [A11y Bug] File picker causes reads of hidden content Oct 4, 2022
@jtimpe jtimpe mentioned this issue Jan 27, 2023
30 tasks
@reitermb reitermb mentioned this issue Sep 15, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility/Section 508 bug dev Refined Ticket has been refined at the backlog refinement V4 - Later Releases
Projects
None yet
Development

No branches or pull requests

5 participants