-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved erd and infrastructure workflows into nested jobs in deploy #2632
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2632 +/- ##
===========================================
- Coverage 92.99% 91.95% -1.05%
===========================================
Files 219 225 +6
Lines 4482 4660 +178
Branches 385 401 +16
===========================================
+ Hits 4168 4285 +117
- Misses 242 296 +54
- Partials 72 79 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just documenting what we discussed after standup. Reinstitute the util/commands and util/jobs and otherwise LGTM
Summary of Changes
In order to reduce the number of times we encounter "Exceded Maximum Number of Workflows" in CircleCI, this PR removes two workflows and moved their jobs into the deploy workflows.
How to Test
CircleCI tests should function the same as before, except with fewer workflows and more sequential tasks in the deploy workflow (but just a few lightweight ones).
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):