Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved erd and infrastructure workflows into nested jobs in deploy #2632

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

George-Hudson
Copy link

Summary of Changes

In order to reduce the number of times we encounter "Exceded Maximum Number of Workflows" in CircleCI, this PR removes two workflows and moved their jobs into the deploy workflows.

How to Test

CircleCI tests should function the same as before, except with fewer workflows and more sequential tasks in the deploy workflow (but just a few lightweight ones).

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • [insert ACs here]
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #2632 (8af6b10) into develop (8ec31f9) will decrease coverage by 1.05%.
Report is 14 commits behind head on develop.
The diff coverage is 87.60%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2632      +/-   ##
===========================================
- Coverage    92.99%   91.95%   -1.05%     
===========================================
  Files          219      225       +6     
  Lines         4482     4660     +178     
  Branches       385      401      +16     
===========================================
+ Hits          4168     4285     +117     
- Misses         242      296      +54     
- Partials        72       79       +7     
Flag Coverage Δ
dev-backend 91.54% <87.60%> (-1.30%) ⬇️
dev-frontend 93.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tdrs-backend/tdpservice/data_files/views.py 90.56% <ø> (ø)
...-backend/tdpservice/search_indexes/admin/filter.py 52.94% <52.94%> (ø)
...pservice/search_indexes/documents/document_base.py 71.42% <71.42%> (ø)
tdrs-backend/tdpservice/parsers/fields.py 81.81% <81.81%> (ø)
tdrs-backend/tdpservice/parsers/parse.py 87.07% <85.21%> (-8.22%) ⬇️
tdrs-backend/tdpservice/parsers/util.py 94.28% <91.30%> (+1.91%) ⬆️
tdrs-backend/tdpservice/parsers/row_schema.py 92.40% <92.40%> (ø)
...s/migrations/0006_alter_parsererror_item_number.py 100.00% <100.00%> (ø)
tdrs-backend/tdpservice/parsers/models.py 92.30% <100.00%> (ø)
...s-backend/tdpservice/parsers/schema_defs/header.py 100.00% <100.00%> (ø)
... and 16 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51fd924...8af6b10. Read the comment docs.

Copy link
Collaborator

@andrew-jameson andrew-jameson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just documenting what we discussed after standup. Reinstitute the util/commands and util/jobs and otherwise LGTM

@andrew-jameson andrew-jameson merged commit 3265cfd into develop Aug 1, 2023
10 checks passed
@andrew-jameson andrew-jameson deleted the ghudson/reduce-workflows branch August 1, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants