-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local PLG MVP #3174
Local PLG MVP #3174
Conversation
- Added loki dashboard and update plg resources - Added backend file logger - UPdated nginx to write logs to file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3044-prometheus-grafana #3174 +/- ##
========================================================
Coverage 91.36% 91.36%
========================================================
Files 290 290
Lines 8044 8044
Branches 751 751
========================================================
Hits 7349 7349
Misses 588 588
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
- Updated logs dashboard with correct loki UID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary of Changes
Pull request closes #3047
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
mkdir -p ~/tdp-logs/nginx
Grafana
tab and checkout theLoki Test
dashboardDeliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
Backend and Frontend servers are monitored by Grafana (availability, cpu usage, HDD usage)Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):