Default to port 3000 while allowing override #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would overwrite the port ENV set by a Dockerfile, so don't think that works. |
With this configuration `bin/dev` will use port 3000, but `bin/dev -p 3001` will correctly start the server on port 3001.
|
@dhh updated so it respects a |
|
could you do the same on cssbundling-rails? thanks |
|
@dhh sure! Here it is rails/cssbundling-rails#124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this configuration
bin/devwill use port 3000, butbin/dev -p 3001will correctly start the server on port 3001.