-
Notifications
You must be signed in to change notification settings - Fork 93
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Silence asset requests with config.assets.quiet (#88)
* config.assets.quiet logger silencing with middleware * add test
- Loading branch information
1 parent
2d8b5bf
commit ce1b5a3
Showing
3 changed files
with
52 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
class Propshaft::QuietAssets | ||
def initialize(app) | ||
@app = app | ||
@assets_regex = %r(\A/{0,2}#{::Rails.application.config.assets.prefix}) | ||
end | ||
|
||
def call(env) | ||
if env['PATH_INFO'] =~ @assets_regex | ||
::Rails.logger.silence { @app.call(env) } | ||
else | ||
@app.call(env) | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
require "test_helper" | ||
require "propshaft/quiet_assets" | ||
|
||
class Propshaft::QuietAssetsTest < ActiveSupport::TestCase | ||
setup do | ||
Rails.logger.level = Logger::DEBUG | ||
end | ||
|
||
test "silences with default prefix" do | ||
assert_equal Logger::ERROR, middleware.call("PATH_INFO" => "/assets/stylesheets/application.css") | ||
end | ||
|
||
test "silences with custom prefix" do | ||
original = Rails.application.config.assets.prefix | ||
Rails.application.config.assets.prefix = "path/to" | ||
assert_equal Logger::ERROR, middleware.call("PATH_INFO" => "/path/to/thing") | ||
ensure | ||
Rails.application.config.assets.prefix = original | ||
end | ||
|
||
test "does not silence without match" do | ||
assert_equal Logger::DEBUG, middleware.call("PATH_INFO" => "/path/to/thing") | ||
end | ||
|
||
private | ||
|
||
def middleware | ||
@middleware ||= Propshaft::QuietAssets.new(->(env) { Rails.logger.level }) | ||
end | ||
end |