Skip to content

Commit

Permalink
Silence asset requests with config.assets.quiet (#88)
Browse files Browse the repository at this point in the history
* config.assets.quiet logger silencing with middleware

* add test
  • Loading branch information
thomascchen committed Apr 30, 2022
1 parent 2d8b5bf commit ce1b5a3
Show file tree
Hide file tree
Showing 3 changed files with 52 additions and 1 deletion.
14 changes: 14 additions & 0 deletions lib/propshaft/quiet_assets.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
class Propshaft::QuietAssets
def initialize(app)
@app = app
@assets_regex = %r(\A/{0,2}#{::Rails.application.config.assets.prefix})
end

def call(env)
if env['PATH_INFO'] =~ @assets_regex
::Rails.logger.silence { @app.call(env) }
else
@app.call(env)
end
end
end
9 changes: 8 additions & 1 deletion lib/propshaft/railtie.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
require "rails"
require "active_support/ordered_options"
require "propshaft/quiet_assets"

module Propshaft
class Railtie < ::Rails::Railtie
Expand All @@ -8,6 +9,7 @@ class Railtie < ::Rails::Railtie
config.assets.excluded_paths = []
config.assets.version = "1"
config.assets.prefix = "/assets"
config.assets.quiet = false
config.assets.compilers = [
[ "text/css", Propshaft::Compilers::CssAssetUrls ],
[ "text/css", Propshaft::Compilers::SourceMappingUrls ],
Expand Down Expand Up @@ -54,14 +56,19 @@ class Railtie < ::Rails::Railtie
Propshaft.logger = config.assets.logger || Rails.logger
end

initializer :quiet_assets do |app|
if app.config.assets.quiet
app.middleware.insert_before ::Rails::Rack::Logger, Propshaft::QuietAssets
end
end

rake_tasks do
load "propshaft/railties/assets.rake"
end

# Compatibility shiming (need to provide log warnings when used)
config.assets.precompile = []
config.assets.debug = nil
config.assets.quiet = nil
config.assets.compile = nil
config.assets.version = nil
config.assets.css_compressor = nil
Expand Down
30 changes: 30 additions & 0 deletions test/propshaft/quiet_assets_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
require "test_helper"
require "propshaft/quiet_assets"

class Propshaft::QuietAssetsTest < ActiveSupport::TestCase
setup do
Rails.logger.level = Logger::DEBUG
end

test "silences with default prefix" do
assert_equal Logger::ERROR, middleware.call("PATH_INFO" => "/assets/stylesheets/application.css")
end

test "silences with custom prefix" do
original = Rails.application.config.assets.prefix
Rails.application.config.assets.prefix = "path/to"
assert_equal Logger::ERROR, middleware.call("PATH_INFO" => "/path/to/thing")
ensure
Rails.application.config.assets.prefix = original
end

test "does not silence without match" do
assert_equal Logger::DEBUG, middleware.call("PATH_INFO" => "/path/to/thing")
end

private

def middleware
@middleware ||= Propshaft::QuietAssets.new(->(env) { Rails.logger.level })
end
end

0 comments on commit ce1b5a3

Please sign in to comment.