Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Vary HTTP header #136

Merged
merged 2 commits into from
Apr 8, 2023
Merged

fix: Vary HTTP header #136

merged 2 commits into from
Apr 8, 2023

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Mar 27, 2023

Accept-Encoding is a request header. The intent here was to set the Vary header to prevent sending responses compressed with modern algorithms to old browsers and sending responses compressed with old suboptimal algorithms to modern browsers.

@brenogazzola brenogazzola merged commit 91c05a4 into rails:main Apr 8, 2023
@brenogazzola
Copy link
Collaborator

@dunglas Thanks for noticing that mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumebriday guillaumebriday guillaumebriday left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunglas @brenogazzola @guillaumebriday