Add a fallback from 'test:prepare' #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheAustinSeven can you squash your commits? |
MixmasterFresh
force-pushed
the
master
branch
from
c0ecdd6
to
4faa9b5
Compare
|
The commits have been squashed. Good catch. |
|
This should be passing, the error seems to not be with the code itself but rather with running bundle install. If it were rerun, it would likely pass. |
| t.pattern = 'test/performance/**/*_test.rb' | ||
| end | ||
| else | ||
| Rails::SubTestTask.new(benchmark: ['db:test:prepare', 'test:perftest:benchmark_mode']) do |t| |
There was a problem hiding this comment.
Do we really need the db:test:prepare dependency? In newer versions of Rails the test database in maintained when running a test. This is ensured by the method ActiveRecord::Migration.maintain_test_schema! in test_help.rb. Since test_help.rb is required by the generated test_helper.rb it's always triggered when running a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix an issue with rails-perftest as mentioned in issue #24. It checks to see if there is a rake task for 'test:prepare', and if there is it will continue as it would normally. Otherwise it falls back to the 'db:test:prepare' rake task. This passes all of the tests (which need to be improved) and I tested it on a few rails apps, and it worked just fine. Resolves #24.