Skip to content

Commit

Permalink
try coveralls_reborn to fix ssl errors.
Browse files Browse the repository at this point in the history
Note that we could also use the coveralls action as recommended
in https://github.com/tagliala/coveralls-ruby-reborn
but it seems like a github token is needed, which makes
it more complex for contributors

This does mean dropping coveralls for EOLed rubies but
do we really need to post to coveralls on each test run?
Wouldn't one test run be enough?
  • Loading branch information
timdiggins committed Jun 15, 2022
1 parent 0def4cf commit 4ee68cb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ end

group :test do
gem "childlabor"
gem "coveralls", ">= 0.8.19"
gem 'coveralls_reborn', '~> 0.23.1', require: false if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.6.0")
gem "rspec", ">= 3.2"
gem "rspec-mocks", ">= 3"
gem "rubocop", "~> 0.50.0"
Expand Down
14 changes: 8 additions & 6 deletions spec/helper.rb
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
$TESTING = true

require "simplecov"
require "coveralls"
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.6.0")
require "simplecov"
require "coveralls"

SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter]
SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter]

SimpleCov.start do
add_filter "/spec"
minimum_coverage(90)
SimpleCov.start do
add_filter "/spec"
minimum_coverage(90)
end
end

$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
Expand Down

0 comments on commit 4ee68cb

Please sign in to comment.