Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI to be green #780

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Fix CI to be green #780

merged 3 commits into from
Jun 15, 2022

Commits on Mar 4, 2022

  1. fix options spec.

    @timdiggins
    timdiggins committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    eea0955 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. fix expectations for ruby 3 treatment of hash arg

    @timdiggins
    timdiggins committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    0def4cf View commit details
    Browse the repository at this point in the history

  2. try coveralls_reborn to fix ssl errors. 

    Note that we could also use the coveralls action as recommended
in https://github.com/tagliala/coveralls-ruby-reborn
but it seems like a github token is needed, which makes
it more complex for contributors

This does mean dropping coveralls for EOLed rubies but
do we really need to post to coveralls on each test run?
Wouldn't one test run be enough?
    @timdiggins
    timdiggins committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    4ee68cb View commit details
    Browse the repository at this point in the history