Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpacker:install leads to a bin/yarn conflict #278

Closed
rubys opened this issue Apr 22, 2017 · 3 comments
Closed

webpacker:install leads to a bin/yarn conflict #278

rubys opened this issue Apr 22, 2017 · 3 comments

Comments

@rubys
Copy link
Contributor

rubys commented Apr 22, 2017

Steps to reproduce

rails new wpinstall
cd wpinstall/
echo "gem 'webpacker', github: 'rails/webpacker'" >> Gemfile
bundle install
rails webpacker:install

Expected behavior

On a clean repository, this should complete without conflict.

Actual behavior

conflict  bin/yarn
Overwrite /home/rubys/git/awdwr/edition4/work-51/depot/bin/yarn? (enter "h" for help) [Ynaqdh] Y
       force  bin/yarn

System configuration

Rails version: 5.1.0.rc2

Ruby version: 2.4.0

@ytbryan
Copy link
Contributor

ytbryan commented Apr 23, 2017

Background: #277 changes the bin/yarn on webpacker.

Yup @y-yagi fixed the bin/yarn on rails.

This can be closed. Thanks for reporting, rubys

@matthewd
Copy link
Member

webpacker should be more explicit about only creating that file if it doesn't exist, so it's only supplying it for pre-5.1 Rails apps. Otherwise we're going to have ongoing cross-version compatibility issues trying to keep them in sync.

@matthewd matthewd reopened this Apr 24, 2017
@ytbryan ytbryan mentioned this issue Apr 25, 2017
@gauravtiwari
Copy link
Member

Fixed by #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants