Fix: NoMethodError - undefined method 'tagged' for #<ActiveSupport::Logger> #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging in latest updates to webpacker master from rails/webpacker
|
|
javan
reviewed
Aug 31, 2017
lib/webpacker/railtie.rb
Outdated
| Webpacker.logger = ::Rails.logger | ||
| if ::Rails.logger.respond_to?(:tagged) | ||
| Webpacker.logger = ::Rails.logger | ||
| end |
There was a problem hiding this comment.
Could create a tagged logger here to preserve the original logger:
if ::Rails.logger.respond_to?(:tagged)
Webpacker.logger = ::Rails.logger
else
Webpacker.logger = ActiveSupport::TaggedLogging.new(::Rails.logger)
end
There was a problem hiding this comment.
I guess we are already doing this here right?
webpacker/lib/webpacker/instance.rb
Line 2 in 68b9f08
There was a problem hiding this comment.
That creates a brand new logger. Doesn't wrap your existing Rails.logger instance.
There was a problem hiding this comment.
Ahh I see, totally missed 👍
There was a problem hiding this comment.
Makes sense... I'll push that today.
|
thanks 🍰 |
|
Happy to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug would be found in versions of Rails applications (<v5) that do not have the default logger set up for tagging. The suggested fix is to check for the method before re-assigning the default webpacker logger to be the rails.logger.