Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: networks and testnet mode e2e #1075

Merged
merged 7 commits into from
Oct 25, 2023
Merged

test: networks and testnet mode e2e #1075

merged 7 commits into from
Oct 25, 2023

Conversation

estebanmino
Copy link
Member

@estebanmino estebanmino commented Oct 20, 2023 •
edited
Loading

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

testnet mode e2e

  • enable/disable testnet from settings
  • enable/disable testnet shortcut from settings
  • enable/disable testnet from menu
  • enable/disable testnet from shortcut

networks

  • testnet / not testnet
  • disabling networks won't show you an option to connect to it

Screen recordings / screenshots

What to test

@estebanmino estebanmino changed the base branch from master to @esteban/testnet-mode October 20, 2023 15:57
@estebanmino estebanmino marked this pull request as ready for review October 20, 2023 15:59
@estebanmino estebanmino changed the title feat: networks and testnet mode e2e test: networks and testnet mode e2e Oct 20, 2023
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-72bccca2e9ee02dd7b2bd286d0824ffe51b4b3ee.zip

BrodyHughes
BrodyHughes approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@BrodyHughes BrodyHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

e2e/parallel/networksAndTestnetModeFlow.test.ts
await clickAcceptRequestButton(driver);

await driver.switchTo().window(dappHandler);
const topButton = await querySelector(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use findElementByTestId here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a dapp button, does it work there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i replaced all three instances of this locally and got ✓ should be able to connect to bx test dapp 16439ms

Copy link
Member Author

@estebanmino estebanmino Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i copy pasted this from other tests so i applied this change everywhere and it doesn't seem to be working for me

image

will skip for this PR

e2e/parallel/networksAndTestnetModeFlow.test.ts
expect(topButton).toBeTruthy();
await waitAndClick(topButton, driver);

const ensLabel = await querySelector(driver, '[id="rk_profile_title"]');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use findElementById here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a dapp label, does it work there?

e2e/parallel/networksAndTestnetModeFlow.test.ts
const modalTitle = await findElementByText(driver, 'Connect a Wallet');
expect(modalTitle).toBeTruthy();

const mmButton = await querySelector(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use findElementByTestId here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a dapp button, does it work there?

derHowie
derHowie approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-d6548f7b767660d8b6479a872eaaa3ea69fe5eb6.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-fda9fbfa72b8bdc801831777a24da0b6965daad3.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-3c5c06bb1f55d9478cb542c9f0d6f3101f3acc3b.zip
screenshots

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-f36cd68bc21e635e85c01d0a8afe856b3439993e.zip

Base automatically changed from @esteban/testnet-mode to master October 25, 2023 13:50
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-3b409e4e6687370f60dd9af7c8065eb9217046ca.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-5e0aae93da6f699a8cbfe5f33dd12fee9fba4874.zip

@estebanmino estebanmino merged commit 3ffb304 into master Oct 25, 2023
16 checks passed
@estebanmino estebanmino deleted the @esteban/testnet-mode-e2e branch October 25, 2023 14:18
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-3ffb304dcee7bd07ef5ea4dec88626b6a4ef79eb.zip

@DanielSinclair DanielSinclair mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrodyHughes BrodyHughes BrodyHughes approved these changes

@derHowie derHowie derHowie approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79

@greg-schrammel greg-schrammel Awaiting requested review from greg-schrammel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @derHowie @BrodyHughes