fix: do not default to mm provider when toggle is off

[estebanmino]

Fixes BX-1088
Figma link (if any):

What changed (plus any additional context for devs)

now:

when our default rnbw provider toggle is off and the user has metamask, we're relaying requests to mm provider
this was probably causing the issue, users had the tooggle off, eip6963 was picking rainbow correctly but we were relaying requests to mm

with this pr:
when our default rnbw provider toggle is off and the user has metamask we're still using rainbow provider if the dapp pick the rainbow provider
this won't affect the window.ethereum override when the rnbw by default tooggle is on since that logic is happening on inpage

Screen recordings / screenshots

What to test

[linear]

BX-1088 6963 should ignore Default Wallet provider toggle

Goal:

• For EIP-6963 provider flow, ignore the MetaMask/default wallet proxy and only expose the Rainbow provider

Report from Uniswap:

hello, I’m noticing an issue with the eip6963 implementation on the rainbow extension. I think your eip6963 provider should only point to rainbow & shouldn’t be taking the default wallet setting into account, that setting should only affect window.ethereum

Screen Recording 2023-10-19 at 11.38.30 AM.mov

[derHowie]

👌

[greg-schrammel]

gotha! nice

[github-actions]

Here's the packed extension for this build:
rainbowbx-19e01a528902a65054a42010e74b56c46df2b29c.zip

[DanielSinclair]

Looks good to me 👌

[github-actions]

Here's the packed extension for this build:
rainbowbx-c997fa0dd2470b667bc5244c1e221d22b3eeb0e4.zip