Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: testnet mode approve sheet #1083

Merged
merged 10 commits into from
Oct 30, 2023
Merged

feat: testnet mode approve sheet #1083

merged 10 commits into from
Oct 30, 2023

Conversation

estebanmino
Copy link
Member

@estebanmino estebanmino commented Oct 24, 2023 •
edited
Loading

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

we're now showing a sheet making the users

  • switch to testnet mode to accept a dapp request if they're connected to a testnet but with testnet mode disabled
  • disable testnet mode to accept a dapp request if they're connected to a mainnet but with testnet mode enabled

Screen recordings / screenshots

https://www.loom.com/share/16f1f9f047c54316bf5409e56db8291d

What to test

@estebanmino estebanmino force-pushed the @esteban/testnet-mode-connect-sheet branch from e4a6b42 to 533ceab Compare October 24, 2023 15:32
@estebanmino estebanmino marked this pull request as ready for review October 24, 2023 15:41
@estebanmino estebanmino force-pushed the @esteban/testnet-mode-connect-sheet branch from 1ea708e to 4586fce Compare October 24, 2023 15:53
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-1239a80a35aa4d97e3c2faac2b374ca9edd27d4d.zip
screenshots

@estebanmino estebanmino force-pushed the @esteban/testnet-mode-connect-sheet branch from 4586fce to a878ae1 Compare October 24, 2023 16:56
@estebanmino estebanmino force-pushed the @esteban/testnet-mode-connect-sheet branch from a878ae1 to 542c649 Compare October 24, 2023 17:00
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0cdea42bf95303d7165ab0e73db3f7632aa3f465.zip
screenshots

brunobar79
brunobar79 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice ux 🤝

src/entries/popup/components/TestnetMode/TestnetModeWatcher/TestnetModeWatcher.tsx Outdated

const [hint, setHint] = useState<Hint>(INITIAL_HINT);

console.log('pendingRequest', pendingRequest);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🧹 🧹

@estebanmino estebanmino force-pushed the @esteban/testnet-mode-connect-sheet branch from 542c649 to 5f94b4e Compare October 25, 2023 13:27
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-042ec9579eca9dc4856c9f9e83ff51ed3058e23d.zip
screenshots

@estebanmino estebanmino force-pushed the @esteban/testnet-mode-connect-sheet branch from 5f94b4e to 6453b83 Compare October 25, 2023 13:58
Base automatically changed from @esteban/testnet-mode-e2e to master October 25, 2023 14:18
@estebanmino estebanmino force-pushed the @esteban/testnet-mode-connect-sheet branch from 6453b83 to 86ef36b Compare October 25, 2023 14:20
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-5b80c92c383713793384aa445bcc7c2d0306faa7.zip
screenshots

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-5b80c92c383713793384aa445bcc7c2d0306faa7.zip
screenshots

@estebanmino estebanmino force-pushed the @esteban/testnet-mode-connect-sheet branch from dcedc78 to 97575b0 Compare October 27, 2023 13:24
derHowie
derHowie approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, small comments

src/entries/popup/components/TestnetMode/TestnetModeWatcher/TestnetModeWatcher.tsx
size="10pt"
weight="bold"
>
🕹️{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing the formatter did this, or do you want the space here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want this

src/entries/popup/components/TestnetMode/TestnetModeWatcher/TestnetModeWatcher.tsx
🕹️{' '}
<TextLink scale={false} color="green">
{i18n.t('testnet_mode_watcher.testnet_mode')}
</TextLink>{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but not this, will fix thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, i do want it, is a link inside a text

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-44d2b6289226ff8d9b786b6840eb5683db49e8aa.zip
screenshots

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-44d2b6289226ff8d9b786b6840eb5683db49e8aa.zip
screenshots

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-e3c4b963834ecb71367b6669d1266b6e9f993e80.zip
screenshots

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-ec7c31d3dd6ebf0b39322c9bd1862848b375474e.zip
screenshots

@estebanmino estebanmino force-pushed the @esteban/testnet-mode-connect-sheet branch from 567d33a to 8cd812b Compare October 30, 2023 17:56
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-bbd92134937a39bb9eef4d7534fd082533d8e665.zip

@estebanmino estebanmino merged commit e499f25 into master Oct 30, 2023
16 checks passed
@estebanmino estebanmino deleted the @esteban/testnet-mode-connect-sheet branch October 30, 2023 18:18
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-e499f25de580346a7d5a00107bf6ded85acaf711.zip

@BrodyHughes BrodyHughes mentioned this pull request Nov 7, 2023
Merged
BrodyHughes pushed a commit that referenced this pull request Nov 15, 2023
@estebanmino @BrodyHughes
feat: testnet mode approve sheet (#1083)
7696263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

@derHowie derHowie derHowie approved these changes

@greg-schrammel greg-schrammel Awaiting requested review from greg-schrammel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @brunobar79 @derHowie