Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network change popup in prod #1101

Merged
merged 7 commits into from
Nov 1, 2023

Conversation

brunobar79
Copy link
Member

Fixes BX-1109
Figma link (if any):

What changed (plus any additional context for devs)

We had to replace the hardcoded occurrences of popup.css after the webpack build is done and use the name given by webpack instead.

Screen recordings / screenshots

PoW: https://recordit.co/7V1DKVVwBO

What to test

Network change popup with dev mode disabled

@linear
Copy link

linear bot commented Oct 30, 2023

BX-1109 Chain switching popup not showing on Uniswap

When changing networks on Uniswap, the user does not see the browser popup notification. There's an error in the console that says "popup.css file not found"

image.png

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-93525574d13ead92dc2798297f1da7233bd4c13c.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-93525574d13ead92dc2798297f1da7233bd4c13c.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-93525574d13ead92dc2798297f1da7233bd4c13c.zip

Copy link
Member

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still don't see it when running the extension with yarn build

https://www.loom.com/share/ad37c823184d4a138fad0aa3848c1471

@brunobar79
Copy link
Member Author

i still don't see it when running the extension with yarn build

https://www.loom.com/share/ad37c823184d4a138fad0aa3848c1471

I made a last minute change and that broke it. It's fixed now. Sorry about that @estebanmino !

@brunobar79 brunobar79 requested a review from a team October 31, 2023 18:12
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-310fd8238fa0831a05f87acc6faa5b4bce2a3e8e.zip

Copy link

Here's the packed extension for this build:
rainbowbx-310fd8238fa0831a05f87acc6faa5b4bce2a3e8e.zip

Copy link
Member

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀

Copy link

github-actions bot commented Nov 1, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-baf2c9e065849311a2d3cc227b7f43f684d8c92f.zip

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

Copy link

github-actions bot commented Nov 1, 2023

Here's the packed extension for this build:
rainbowbx-f1b3646f1895711ddeacc9cfafdca8507c6405a7.zip

@brunobar79 brunobar79 merged commit 9011ccd into master Nov 1, 2023
16 checks passed
@brunobar79 brunobar79 deleted the @bruno/fix-network-change-popup-prod branch November 1, 2023 19:54
Copy link

github-actions bot commented Nov 1, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9011ccd1adf7f23ce1dcc6c5d8e034c1c1a6e685.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants