-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix network change popup in prod #1101
Conversation
BX-1109 Chain switching popup not showing on Uniswap
When changing networks on Uniswap, the user does not see the browser popup notification. There's an error in the console that says "popup.css file not found" |
Here's the packed extension for this build: |
… @bruno/fix-network-change-popup-prod
Here's the packed extension for this build: |
Here's the packed extension for this build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i still don't see it when running the extension with yarn build
… @bruno/fix-network-change-popup-prod
I made a last minute change and that broke it. It's fixed now. Sorry about that @estebanmino ! |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 🚀
Here's the packed extension for this build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Fixes BX-1109
Figma link (if any):
What changed (plus any additional context for devs)
We had to replace the hardcoded occurrences of
popup.css
after the webpack build is done and use the name given by webpack instead.Screen recordings / screenshots
PoW: https://recordit.co/7V1DKVVwBO
What to test
Network change popup with dev mode disabled