Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BX-1122] fix context menu swap prepop #1118

Merged
merged 3 commits into from
Nov 8, 2023
Merged

[BX-1122] fix context menu swap prepop #1118

merged 3 commits into from
Nov 8, 2023

Conversation

derHowie
Copy link
Member

@derHowie derHowie commented Nov 6, 2023

make sure swap prepopulates with the selected token when navigating from the asset context menu

PoW: https://recordit.co/jhDnDIsxeL

Copy link

linear bot commented Nov 6, 2023

BX-1122 Opening Swap from token context menu is not correctly prepopulating the Swap UI with the token

when a user right clicks a token in their wallet and then clicks Swap it should prefill the Swap UI with the input currency being set to the token they right clicked on
currently it just opens the Swap UI and makes the user choose an input currency which is incredibly confusing (i keep on getting confused when i go thru this flow)
video of me going thru this flow 👉 https://p163.p2.n0.cdn.getcloudapp.com/items/JrumpKx5/2c5c8466-ae6d-4021-9724-43a952db1130.mov?v=3f69b241f9474165a24acf4acaf04dcf

screenshot what the user should be seeing when they right click a token and choose Swap from the context menu https://p163.p2.n0.cdn.getcloudapp.com/items/xQuNRBN8/69090391-27af-4035-adfe-e617ce27ea97.png?v=f96aabf50e9f6fd1bb4b7b2243a0bf8f

Copy link

github-actions bot commented Nov 7, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-910ea3798d4310c53345ca4762f0cc2c40958ef1.zip

@mikedemarais
Copy link

i love chris 🫶

Copy link

github-actions bot commented Nov 7, 2023

Here's the packed extension for this build:
rainbowbx-8eeb661ad2d067562aa588b2c42292272daf43ae.zip

Copy link

github-actions bot commented Nov 8, 2023

Here's the packed extension for this build:
rainbowbx-4686e54820ea490417907b885fe8154420408939.zip

@derHowie derHowie merged commit 859a773 into master Nov 8, 2023
15 checks passed
@derHowie derHowie deleted the @chris/prepop-swap branch November 8, 2023 16:18
Copy link

github-actions bot commented Nov 8, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-859a773faa2b66971a162770b224dbb779d2333a.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants