Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asset filtering by networks settings #1124

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

estebanmino
Copy link
Member

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

filtering assets by network broke, so any change on networks settings weren't filtering assets correctly, this pr fixes that

Screen recordings / screenshots

What to test

Copy link
Contributor

@greg-schrammel greg-schrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link

github-actions bot commented Nov 8, 2023

Here's the packed extension for this build:
rainbowbx-9dd3adb32bca4d865f9cb1393bc1783b75d2ec97.zip

@brunobar79 brunobar79 merged commit aff3ea5 into master Nov 8, 2023
3 checks passed
@brunobar79 brunobar79 deleted the @esteban/fix-asset-filtering-by-networks branch November 8, 2023 20:18
Copy link

github-actions bot commented Nov 8, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-aff3ea5f063a8981054afce8814ffa965348bd7a.zip

BrodyHughes pushed a commit that referenced this pull request Nov 15, 2023
Co-authored-by: Bruno Barbieri <1247834+brunobar79@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants