fix: testnet native send #1130
Merged
fix: testnet native send #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derHowie
approved these changes
Nov 13, 2023
brunobar79
approved these changes
Nov 13, 2023
|
Here's the packed extension for this build: |
estebanmino
force-pushed
the
@esteban/fix-testnet-send
branch
from
8d6d02a
to
922ce7d
Compare
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
BrodyHughes
pushed a commit
that referenced
this pull request
Nov 15, 2023
Co-authored-by: Bruno Barbieri <1247834+brunobar79@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
txs were going out to 0x..000 address when sending native assets on testnets because
isNativeAssetwasn't checking for the right addressScreen recordings / screenshots
What to test