Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

points onboarding animations #1174

Merged
merged 16 commits into from
Dec 7, 2023
Merged

Conversation

estebanmino
Copy link
Member

@estebanmino estebanmino commented Dec 5, 2023

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

  • correct animations
  • now sending users to but and swap at the end of registration, but if there's no balance and swap if there is
  • blocking watched wallets

Screen recordings / screenshots

Screen.Recording.2023-12-05.at.17.10.58.mov
Screen.Recording.2023-12-05.at.17.09.56.mov

What to test

Copy link

github-actions bot commented Dec 5, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-11cb0e40792fa1f2fdbef45d41e6f9bac5f7fcd2.zip
screenshots

@estebanmino estebanmino marked this pull request as ready for review December 5, 2023 20:48
Copy link

github-actions bot commented Dec 5, 2023

Here's the packed extension for this build:
rainbowbx-c60e7e672dd82d4b6fb1b418e85bc9294f2d794c.zip

Copy link

github-actions bot commented Dec 5, 2023

Here's the packed extension for this build:
rainbowbx-9bcf871bf1e809228617b81c63f55f530983c395.zip

Base automatically changed from @esteban/points-onboarding to master December 6, 2023 17:32
@estebanmino estebanmino force-pushed the @esteban/points-onboarding-tweaks branch from c7123ab to eb5cc43 Compare December 6, 2023 17:34
Copy link

github-actions bot commented Dec 6, 2023

Here's the packed extension for this build:
rainbowbx-d050bf5f9e286a03d061c37958d412b999a5f006.zip

Copy link

github-actions bot commented Dec 6, 2023

Here's the packed extension for this build:
rainbowbx-6ced35dae7b96fece0c42d0be39e7c30a7e98845.zip

Comment on lines 42 to 106
export const DUMMY_USER = {
categories: [
{
data: {
owned_collections: 0,
total_collections: 0,
usd_amount: 1,
},
type: 'metamask-swaps' as CATEGORY_TYPE,
display_type: 'USD_AMOUNT' as CATEGORY_DISPLAY_TYPE,
earnings: { total: 0 },
},
{
data: {
owned_collections: 0,
total_collections: 0,
usd_amount: 1,
},
type: 'rainbow-bridges' as CATEGORY_TYPE,
display_type: 'USD_AMOUNT' as CATEGORY_DISPLAY_TYPE,
earnings: { total: 0 },
},
{
data: {
owned_collections: 1,
total_collections: 10,
usd_amount: 1,
},
type: 'nft-collections' as CATEGORY_TYPE,
display_type: 'NFT_COLLECTION' as CATEGORY_DISPLAY_TYPE,
earnings: { total: 0 },
},
{
data: {
owned_collections: 0,
total_collections: 0,
usd_amount: 1,
},
type: 'historic-balance' as CATEGORY_TYPE,
display_type: 'USD_AMOUNT' as CATEGORY_DISPLAY_TYPE,
earnings: { total: 0 },
},
{
data: {
owned_collections: 0,
total_collections: 0,
usd_amount: 1,
},
type: 'bonus' as CATEGORY_TYPE,
display_type: 'BONUS' as CATEGORY_DISPLAY_TYPE,
earnings: { total: 1 },
},
{
data: {
owned_collections: 0,
total_collections: 0,
usd_amount: 1,
},
type: 'rainbow-swaps' as CATEGORY_TYPE,
display_type: 'USD_AMOUNT' as CATEGORY_DISPLAY_TYPE,
earnings: { total: 0 },
},
],
earnings: { total: 100 },
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing

Copy link
Contributor

@greg-schrammel greg-schrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some colors could change, don't like that green lol, but the animations are cool!

Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

customTypingSpeed?: number;
}) => {
if (typeof children !== 'string') {
console.error('AnimatedText expects a string as children');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we wanna leave this here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing, was copy pasta

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i need it, i put children.split('') just below to animate the characters

INVALID_REFERRAL_CODE_ERROR,
} from './references';

export const CHARACTER_TYPING_SPEED = 0.1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is a bit too slow. I'd lower it down to 0.05 or check what the app is using cause it def. seems faster there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i followed the app that had 0.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i just found 20 in other place, switching

@estebanmino
Copy link
Member Author

I think some colors could change, don't like that green lol, but the animations are cool!

@greg-schrammel yeah, i changed the color for the one in figma

@estebanmino
Copy link
Member Author

also, updated action buttons

image
image

Copy link

github-actions bot commented Dec 6, 2023

Here's the packed extension for this build:
rainbowbx-b756a230bfb7aae1712ae39f85f0e6d23e655884.zip

@estebanmino estebanmino force-pushed the @esteban/points-onboarding-tweaks branch from 0674fda to ba08e4f Compare December 7, 2023 13:52
Copy link

github-actions bot commented Dec 7, 2023

Here's the packed extension for this build:
rainbowbx-44a8b64b581d9c27ad52fbe103472dd0cb9d22b5.zip

@estebanmino estebanmino merged commit 2bf8f1b into master Dec 7, 2023
17 checks passed
@estebanmino estebanmino deleted the @esteban/points-onboarding-tweaks branch December 7, 2023 14:11
Copy link

github-actions bot commented Dec 7, 2023

Here's the packed extension for this build:
rainbowbx-2bf8f1b74603f15da06dfa8ca78fcf75531fc428.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants