-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
points onboarding animations #1174
Conversation
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
c7123ab
to
eb5cc43
Compare
Here's the packed extension for this build: |
Here's the packed extension for this build: |
export const DUMMY_USER = { | ||
categories: [ | ||
{ | ||
data: { | ||
owned_collections: 0, | ||
total_collections: 0, | ||
usd_amount: 1, | ||
}, | ||
type: 'metamask-swaps' as CATEGORY_TYPE, | ||
display_type: 'USD_AMOUNT' as CATEGORY_DISPLAY_TYPE, | ||
earnings: { total: 0 }, | ||
}, | ||
{ | ||
data: { | ||
owned_collections: 0, | ||
total_collections: 0, | ||
usd_amount: 1, | ||
}, | ||
type: 'rainbow-bridges' as CATEGORY_TYPE, | ||
display_type: 'USD_AMOUNT' as CATEGORY_DISPLAY_TYPE, | ||
earnings: { total: 0 }, | ||
}, | ||
{ | ||
data: { | ||
owned_collections: 1, | ||
total_collections: 10, | ||
usd_amount: 1, | ||
}, | ||
type: 'nft-collections' as CATEGORY_TYPE, | ||
display_type: 'NFT_COLLECTION' as CATEGORY_DISPLAY_TYPE, | ||
earnings: { total: 0 }, | ||
}, | ||
{ | ||
data: { | ||
owned_collections: 0, | ||
total_collections: 0, | ||
usd_amount: 1, | ||
}, | ||
type: 'historic-balance' as CATEGORY_TYPE, | ||
display_type: 'USD_AMOUNT' as CATEGORY_DISPLAY_TYPE, | ||
earnings: { total: 0 }, | ||
}, | ||
{ | ||
data: { | ||
owned_collections: 0, | ||
total_collections: 0, | ||
usd_amount: 1, | ||
}, | ||
type: 'bonus' as CATEGORY_TYPE, | ||
display_type: 'BONUS' as CATEGORY_DISPLAY_TYPE, | ||
earnings: { total: 1 }, | ||
}, | ||
{ | ||
data: { | ||
owned_collections: 0, | ||
total_collections: 0, | ||
usd_amount: 1, | ||
}, | ||
type: 'rainbow-swaps' as CATEGORY_TYPE, | ||
display_type: 'USD_AMOUNT' as CATEGORY_DISPLAY_TYPE, | ||
earnings: { total: 0 }, | ||
}, | ||
], | ||
earnings: { total: 100 }, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some colors could change, don't like that green lol, but the animations are cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
customTypingSpeed?: number; | ||
}) => { | ||
if (typeof children !== 'string') { | ||
console.error('AnimatedText expects a string as children'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we wanna leave this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing, was copy pasta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i need it, i put children.split('')
just below to animate the characters
INVALID_REFERRAL_CODE_ERROR, | ||
} from './references'; | ||
|
||
export const CHARACTER_TYPING_SPEED = 0.1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is a bit too slow. I'd lower it down to 0.05 or check what the app is using cause it def. seems faster there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i followed the app that had 0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i just found 20 in other place, switching
@greg-schrammel yeah, i changed the color for the one in figma |
Here's the packed extension for this build: |
0674fda
to
ba08e4f
Compare
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
Screen recordings / screenshots
Screen.Recording.2023-12-05.at.17.10.58.mov
Screen.Recording.2023-12-05.at.17.09.56.mov
What to test