Fix custom networks assets #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… @bruno/fix-custom-networks-assets
|
Here's the packed extension for this build: |
| import { useCurrentCurrencyStore } from '~/core/state'; | ||
| import { convertAmountToNativeDisplay } from '~/core/utils/numbers'; | ||
| import { add, convertAmountToNativeDisplay } from '~/core/utils/numbers'; | ||
|
|
||
| export function useUserAssetsBalance() { | ||
| const { address } = useAccount(); |
There was a problem hiding this comment.
wanna make this useCurrentAddressStore since where here?
Comment on lines
+42
to
+43
| totalAssetsBalanceKnownNetworks as string, | ||
| totalAssetsBalanceCustomNetworks as string, |
There was a problem hiding this comment.
won't add break if one of these are undefined?
There was a problem hiding this comment.
The selector returns '0' by default so we're good
greg-schrammel
approved these changes
Dec 8, 2023
… @bruno/fix-custom-networks-assets
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
There were a few bugs with custom networks
Screen recordings / screenshots
Ex. with Anvil as a custom RPC
What to test